Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] update text to support color longs #43164

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Android] update text to support color longs #43164

wants to merge 1 commit into from
+88 −40

Conversation

ryanlntn
Copy link
Contributor

Summary:

This builds on previous PRs for the wide gamut color RFC and extends Android text with support for DisplayP3 color.

Changelog:

[ANDROID] [ADDED] - Add DisplayP3 color support to Text

Test Plan:

  1. Pull changes from these previous PRs:
    [JS] Add support for CSS4 color() functions #42831
    [Android] MapBuffer long support #43030
    [Android] Update ColorPropConverterto support color function values #43031
    [Android] Add isWideColorGamutEnabled to ReactActivityDelegate #43036
    [Android] Update bridge to handle long values #43158
    [Android] Update HostPlatformColor to support color longs #43163
  2. Follow the test steps for each PR
  3. Pull these changes and build RNTester for Android: cd packages/rn-tester && yarn android
  4. Navigate to ViewExample and observe DisplayP3 text color

Screenshot_20240131-100112

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Infinite Red Partner: Infinite Red Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Feb 23, 2024
@ryanlntn ryanlntn force-pushed the feat/wide-gamut-color-android-text branch 2 times, most recently from c95136e to 3713d0f Compare March 15, 2024 10:35
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi
Copy link
Contributor

Hi @ryanlntn, sorry for the looooong delay in working on this. This PR has some conflicts that prevent it from being properly imported. Would you mind to rebase this and try to solve them, so I can import the PR?

@ryanlntn ryanlntn force-pushed the feat/wide-gamut-color-android-text branch from 3713d0f to 3334b68 Compare April 4, 2024 16:27
@ryanlntn
Copy link
Contributor Author

ryanlntn commented Apr 4, 2024

@cipolleschi No worries and no problem. I just got back myself. Hope you had an excellent vacation. Rebased and ready to respond to any and all feedback! 😄

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@react-native-bot react-native-bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 3, 2024
@react-native-bot
Copy link
Collaborator

This PR was closed because it has been stalled for 7 days with no activity.

@cipolleschi cipolleschi reopened this Oct 10, 2024
@react-native-bot react-native-bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Infinite Red Partner: Infinite Red Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryanlntn @facebook-github-bot @cipolleschi @react-native-bot